-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add e2e signing and ethereum tests #549
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Add ethereum account deletion test |
hanwencheng
force-pushed
the
hanwen-e2e-signing
branch
from
March 3, 2020 16:34
965143b
to
b08725a
Compare
hanwencheng
changed the title
test: Improve on e2e signing
test: add e2e signing and ethereum tests
Mar 3, 2020
sjeohp-zz
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improve current e2e tests.
1. Add more tests for Substrate signing
Now we have two e2e suites: one is for key management and path derivation, the other is for signing test.
e2e/signing.spec.ts
|--Single QR Extrinsic (Sign TX)
|---SetRemark
|---Transfer
|--Multi Part QR Extrinsic(Sign Message)
|---SetRemark
2. Add the Ethereum account tests: generation, deletion, and signing
e2e/signing.spec.ts
-Ethereum
|--Sign Transaction
|--Sign Message
e2e/identityManipulation.spec.ts
-Ethereum
|--Account Creation
|--Account Deletion
3. Reformat project layout for units test and e2e test
previously:
currently:
Since
Detox
and Unit test both useJest
as test runner, and they share similar parts of the configs, now move them together into thetest
folder, which brings a clear structure layout and configuration.4. How to test
yarn
to upgrade dependenciesyarn start --reset-cache
yarn e2e:ios
to test on ios, andyarn e2e:android
for the android test suits. notice: android e2e may be not stable with pin code input, sometime input is missing, just try again will fix the erroryarn unit
should succeed.