Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Input to reintroduce KeyStateFrameChangeLog #591

Merged
merged 20 commits into from
Nov 11, 2023

Conversation

capnkenny
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • [N/A] Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Modifies the Input low-level systems to use GLFW's callbacks instead of polling.
Also re-adds the frame changelog functionality from the legacy InteractionService to work with our "Mapped Actions".

Copy link
Member

@RubyNova RubyNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some required changes and some questions for ya

input/Glfw/GlfwInputDevice.cpp Outdated Show resolved Hide resolved
input/Glfw/GlfwInputDevice.cpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/IInputDevice.hpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/IInputDevice.hpp Show resolved Hide resolved
input/include/NovelRT/Input/InputAction.hpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/KeyState.hpp Show resolved Hide resolved
input/include/NovelRT/Input/KeyStateFrameChangeLog.hpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/KeyStateFrameChangeLog.hpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/NovelKey.hpp Outdated Show resolved Hide resolved
@capnkenny
Copy link
Member Author

capnkenny commented Oct 29, 2023

I will note that as per our header includes, we're to begin moving away from the all-inclusive header - i.e. "Input.hpp" - however we haven't actually done that yet (such as with Graphics and Audio), and I rather keep this PR from hitting a larger amount of scope growth
I have proven myself to be a liar :( but the dark deed is done and the centralised header is no more

@capnkenny capnkenny requested a review from RubyNova October 29, 2023 22:56
input/Glfw/GlfwInputDevice.cpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/Glfw/GlfwInputDevice.hpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/IInputDevice.hpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/InputAction.hpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/KeyState.hpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/NovelKey.hpp Outdated Show resolved Hide resolved
@capnkenny capnkenny requested a review from RubyNova November 1, 2023 22:39
input/Glfw/GlfwInputDevice.cpp Outdated Show resolved Hide resolved
input/Glfw/GlfwInputDevice.cpp Outdated Show resolved Hide resolved
input/Glfw/GlfwInputDevice.cpp Outdated Show resolved Hide resolved
input/Glfw/GlfwInputDevice.cpp Outdated Show resolved Hide resolved
input/Glfw/GlfwInputDevice.cpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/IInputDevice.hpp Show resolved Hide resolved
input/include/NovelRT/Input/InputAction.hpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/KeyState.hpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/KeyStateFrameChangeLog.hpp Outdated Show resolved Hide resolved
input/include/NovelRT/Input/NovelKey.hpp Outdated Show resolved Hide resolved
@capnkenny capnkenny requested a review from RubyNova November 7, 2023 11:54
@capnkenny capnkenny enabled auto-merge November 7, 2023 12:07
Copy link

github-actions bot commented Nov 7, 2023

Test Results

       4 files         4 suites   1m 31s ⏱️
   693 tests    693 ✔️ 0 💤 0
2 772 runs  2 772 ✔️ 0 💤 0

Results for commit b68ddda.

Copy link
Member

@RubyNova RubyNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@capnkenny capnkenny merged commit 97c1823 into main Nov 11, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants