Platform-specific Audio #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves an issue where spdlog's bundled fmt lib was using deprecated/non-standard MSFT extensions that Windows was removing soon
No audio playing due to bad handling of buffers
Kind of retrofitted to current ECS setup? but the point was to make it playback using OAL first and in a separate static lib.
Need to fix Ogg playback
…to interruptions unhandled
Need to finish standardising samplerate conversion support and formats for XAudio and OpenAL
Resolves an issue where spdlog's bundled fmt lib was using deprecated/non-standard MSFT extensions that Windows was removing soon
No audio playing due to bad handling of buffers
Kind of retrofitted to current ECS setup? but the point was to make it playback using OAL first and in a separate static lib.
Need to fix Ogg playback
…to interruptions unhandled
Need to finish standardising samplerate conversion support and formats for XAudio and OpenAL
capnkenny
force-pushed
the
feature/audio-system
branch
from
87d3728 to
d517243
Compare
capnkenny
requested review from
RubyNova,
FiniteReality and
tannergooding
as code owners
RubyNova
reviewed
Jul 28, 2024
Comment on lines
+56
to
+58
| alGetError(); | ||
| alSourceStopv(static_cast<int>(_sources.size()), reinterpret_cast<ALuint*>(_sources.data())); | ||
| GetALError(); |
There was a problem hiding this comment.
Can I ask what the difference is between alGetError and GetALError?
There was a problem hiding this comment.
One gets the error code from OpenAL and clears the error register internally (from OpenAL's side) - the other (GetALError) does that plus actually parses the error code into something human-readable
| { | ||
| case AL_INVALID_NAME: | ||
| { | ||
| _logger->error("A bad ID or name was passed to the OpenAL function."); |
There was a problem hiding this comment.
Are we directly using spdlog due to the deprecation of the old APIs?
There was a problem hiding this comment.
Yes - in this case its easier to do so, and since there's some uncertainty around how the APIs will be used going forward (with the great big refactor) it was just cleaner to do so, so that I could continue to keep the static lib isolated to itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Removes the legacy AudioService and adds the new AudioMixer and OS specific implementations.
What is the new behavior (if this is a feature change)?
Users should begin using the AudioMixer interface and let it choose the backing audio platform automatically.