Support ExtendedDesktopSize and SetDesktopSize #444
Conversation
* Split viewportChange into two functions, one for changing size and the other for changing position. * Modified viewport code to be capable of changing to a bigger size in the context of a client-initiated resize. * Made clearer distinctions between when viewport-clipping or not. * Added public function for telling when viewport-clipping. * Updated tests that were using viewportChange.
* Support sending the setDesktopSize encoding (client -> server) * Support recieving the ExtendedDesktopSize encoding (server <- client)
|
LGTM 👍 Just needs tests. It will be great to have this. P.S. For future reference, you don't have to open a new PR -- you can just edit the existing branch that the PR is based off of ( |
|
There we go, I think these tests should be sufficient, the changes in display.js should be covered by existing tests. I think ui changes are difficult to write unit tests for since they are closely dependent on HTML elements?
Will do! |
|
The unit tests look good. I caught one last thing right before I went to merge, however. Fix that, then we'll merge this. |
* Added a resize request (setDesktopSize) triggered when connecting and by changes to the browser window's size. * Hid the view-drag-hand when the display area is the same or smaller than the remote session size. * Added a setting for the automatic resize feature. * Updated vnc.html and vnc_auto.html to reflect the changes to the UI.
* Added new tests for the setDesktopSize encoding * Added new tests for the ExtendedDesktopSize encoding
|
Good catch, thank you! Should all be good now. |
Support ExtendedDesktopSize and SetDesktopSize
Cleaned up version of #271
This feature is divided into 4 commits:
1: display.js
2: rfb.js
3: ui.js, vnc.html & vnc_auto.html
4: tests