Pass token into the path variable #537
Conversation
|
@miguelxpn : I think this could have issues if someone already has |
|
@DirectXMan12 You are absolutely right, I changed my commit and it should be ok now. |
If token is already present in path the new variable is ignored.
|
Made a new commit adding a separate token variable in vnc.html and ui.js, if the token is already present in the path then this new variable is ignored so it doesn't break anything for people using it in the old way. |
| var path = $D('noVNC_path').value; | ||
|
|
||
| //if token is in path then ignore the new token variable | ||
| if (token && !(path.indexOf("token") > -1)){ |
There was a problem hiding this comment.
Doesn't this cause the token insertion not to trigger if I have
path = "/token", in which case a path of token?token=[foo] is perfectly valid.
There was a problem hiding this comment.
We should be able to fix this by using the an <a> element in memory, and using that to manipulate the path.
|
Besides the issue I noted, this LGTM 👍. I'll make the change, rebase, and merge. |
Fixes #536