Resize Receive Queue to Fit Incoming Messages #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `copyWithin` function of typed arrays has performance issues in some versions of Chromium, and doesn't doesn't have enough of a performance impact to justify leaving it enabled.
|
@DirectXMan12 looks good. Should we add a test for this function? |
Yep, good catch. Will do. |
This commit causes the receive queue to dynamically resize to fit incoming messages. Fixes #557
DirectXMan12
force-pushed
the
bug/dynamic-rq-resize
branch
from
5bfdd90
to
40037b6
Compare
|
@kanaka test added. I'll merge shortly unless anyone has any objections. |
|
@DirectXMan12 no objections here. |
|
LGTM! |
DirectXMan12
added a commit
that referenced
this pull request
Jan 5, 2016
Resize Receive Queue to Fit Incoming Messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes the receive queue to be resized in order to fit incoming messages. There is a hard cap of a size of 40 MiB, so that we can't consume too much memory by accident.
Fixes #557