This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Issues/177: Update Gradle internal api implementation #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussion we realised that providing a solution to #177 that is not relying on the use of a Gradle internal API is simply not viable, as we would need to basically duplicate the functionality provided by that same API, as the generation of the correct POM descriptor including scopes and excluding rules for each of the dependencies is more complicated than anticipated.
After a chat with a couple of colleagues and after a catchup with @eriwen we decided to make our plugin to use the updated Gradle internal API (
SoftwareComponentInternal, more info at #112), which will force this plugin to bump the minimum Gradle version supported to 4.5 (totally acceptable in real-world projects, considering also that the latest Gradle version at the moment is 4.10.2).