This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Inherit the SDK path from the android plugin #70
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
05bf012
Inherit the SDK path from the android plugin avoiding to duplicate su…
emanuelez 9cc24c4
Rename a variable for readability
emanuelez 9f77c69
Extract androidHome detection logic in a private static method.
emanuelez 8c05f12
Make the SDK detection more robust
emanuelez 36c8158
Adhere to coding standards
emanuelez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ package com.novoda.gradle.command | |
import org.gradle.testfixtures.ProjectBuilder | ||
|
||
class AndroidCommandPluginExtensionTest extends GroovyTestCase { | ||
static private final String SDK_PATH = '/some/path' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be ordered |
||
|
||
void testDefaultAdbPath() { | ||
def extension = createExtension() | ||
|
@@ -11,7 +12,7 @@ class AndroidCommandPluginExtensionTest extends GroovyTestCase { | |
|
||
void testDefaultAndroidHomePath() { | ||
def extension = createExtension() | ||
assert extension.androidHome != null | ||
assert extension.androidHome == SDK_PATH | ||
} | ||
|
||
void testDefaultEvents() { | ||
|
@@ -27,7 +28,7 @@ class AndroidCommandPluginExtensionTest extends GroovyTestCase { | |
private static AndroidCommandPluginExtension createExtension() { | ||
def projectDir = new File('..') | ||
def project = ProjectBuilder.builder().withProjectDir(projectDir).build() | ||
def extension = new AndroidCommandPluginExtension(project) | ||
def extension = new AndroidCommandPluginExtension(project, SDK_PATH) | ||
extension | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍