Skip to content

Commit

Permalink
Merge pull request #177 from mattleibow/patch-2
Browse files Browse the repository at this point in the history
Add a workaround for #176
  • Loading branch information
Oren Novotny authored Aug 13, 2019
2 parents 6a55d19 + bb2a609 commit 8ce9859
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,12 @@
<Error Text="The Binding Project for $(_SdkTargetPlatformName) is only supported with only C#, not with $(_SdkLanguageSourceName). Please change the project to C# to use the Bindings Project.'"/>
</Target>

<!-- A workaround for https://github.com/microsoft/msbuild/issues/4584 and resolves https://github.com/onovotny/MSBuildSdkExtras/issues/176 -->
<Target Name="_RemoveNativeReferencesManifest" Condition="'$(IsApplePlatform)' == 'true'" AfterTargets="BuiltProjectOutputGroup">
<ItemGroup>
<_BuiltProjectOutputGroupOutputIntermediate Remove="$(OutDir)$(_DeploymentTargetApplicationManifestFileName)" />
<BuiltProjectOutputGroupOutput Remove="$(ProjectDir)$(OutDir)$(_DeploymentTargetApplicationManifestFileName)" />
</ItemGroup>
</Target>

</Project>
4 changes: 4 additions & 0 deletions Tests/ClasslibraryAsSdk/ClasslibraryAsSdk.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@
<Reference Include="System.Xml" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'xamarin.ios10'">
<NativeReference Include="Resource1.resx" />
</ItemGroup>

<ItemGroup Condition=" $(TargetFramework.StartsWith('uap')) ">
<Page Include="uwp\**\*.xaml"/>
<Compile Include="uwp\**\*.cs" />
Expand Down

0 comments on commit 8ce9859

Please sign in to comment.