feat: remove Notification Templates as part of the API as it is now o…

…bsolete #59

src/Novu.Extensions/IocNovuRegistrationExtensions.cs

@@ -3,7 +3,6 @@
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Novu.Interfaces;
-using Novu.NotificationTemplates;
 using Refit;
 
 namespace Novu.Extensions;
@@ -19,7 +18,6 @@ public static IServiceCollection RegisterNovuClients(
         RefitSettings refitSettings = null)
     {
         var novuConfiguration = configuration.GetNovuClientConfiguration();
-        services.AddTransient<INovuClientConfiguration>(_ => novuConfiguration);
 
         Action<HttpClient> configureClient = c =>
         {
@@ -42,7 +40,6 @@ public static IServiceCollection RegisterNovuClients(
         services.AddRefitClient<IEventClient>(settings).ConfigureHttpClient(configureClient);
         services.AddRefitClient<ITopicClient>(settings).ConfigureHttpClient(configureClient);
         services.AddRefitClient<IWorkflowGroupClient>(settings).ConfigureHttpClient(configureClient);
-        services.AddRefitClient<INotificationTemplatesClient>(settings).ConfigureHttpClient(configureClient);
         services.AddRefitClient<IWorkflowClient>(settings).ConfigureHttpClient(configureClient);
         services.AddRefitClient<ILayoutClient>(settings).ConfigureHttpClient(configureClient);
         services.AddRefitClient<IIntegrationClient>(settings).ConfigureHttpClient(configureClient);
@@ -51,6 +48,7 @@ public static IServiceCollection RegisterNovuClients(
         services.AddRefitClient<IExecutionDetailsClient>(settings).ConfigureHttpClient(configureClient);
 
         return services
+            .AddTransient<INovuClientConfiguration>(_ => novuConfiguration)
             .AddTransient<INovuClient, NovuClient>();
     }
 }

src/Novu.Tests/IntegrationTests/BaseIntegrationTest.cs

@@ -20,7 +20,6 @@
 using Novu.Models.Subscribers;
 using Novu.Models.Workflows;
 using Novu.Models.Workflows.Step.Message;
-using Novu.NotificationTemplates;
 using Novu.Sync;
 using ParkSquare.Testing.Generators;
 using Refit;
@@ -62,7 +61,6 @@ protected BaseIntegrationTest(ITestOutputHelper output)
     protected IEventClient Event => Get<IEventClient>();
     protected ITopicClient Topic => Get<ITopicClient>();
     protected IWorkflowGroupClient WorkflowGroup => Get<IWorkflowGroupClient>();
-    protected INotificationTemplatesClient NotificationTemplates => Get<INotificationTemplatesClient>();
     protected IWorkflowClient Workflow => Get<IWorkflowClient>();
     protected ILayoutClient Layout => Get<ILayoutClient>();
     protected IIntegrationClient Integration => Get<IIntegrationClient>();

src/Novu/Interfaces/INovuClient.cs

@@ -1,16 +1,11 @@
-using Novu.NotificationTemplates;
-
-namespace Novu.Interfaces;
+namespace Novu.Interfaces;
 
 public interface INovuClient
 {
-    public ISubscriberClient Subscriber { get; }
-
-    public IEventClient Event { get; }
-
-    public ITopicClient Topic { get; }
-    public INotificationTemplatesClient NotificationTemplates { get; }
-    public IWorkflowGroupClient WorkflowGroup { get; }
+    ISubscriberClient Subscriber { get; }
+    IEventClient Event { get; }
+    ITopicClient Topic { get; }
+    IWorkflowGroupClient WorkflowGroup { get; }
     IWorkflowClient Workflow { get; }
     ILayoutClient Layout { get; }
     IIntegrationClient Integration { get; }

src/Novu/Novu.csproj

@@ -38,6 +38,10 @@
     </ItemGroup>
     <ItemGroup>
       <Compile Remove="JsonConverters\EnumMemberExtensions.cs" />
+      <Compile Remove="NotificationTemplates\Child.cs" />
+      <Compile Remove="NotificationTemplates\Filter.cs" />
+      <Compile Remove="NotificationTemplates\Step.cs" />
+      <Compile Remove="NotificationTemplates\Trigger.cs" />
     </ItemGroup>
 
 </Project>

src/Novu/NovuClient.cs

@@ -2,7 +2,6 @@
 using Newtonsoft.Json.Converters;
 using Newtonsoft.Json.Serialization;
 using Novu.Interfaces;
-using Novu.NotificationTemplates;
 using Refit;
 
 namespace Novu;
@@ -24,34 +23,6 @@ public class NovuClient : INovuClient
         },
     };
 
-    public NovuClient(INovuClientConfiguration configuration) : this(configuration, default)
-    {
-    }
-
-    public NovuClient(
-        ISubscriberClient subscriber,
-        IEventClient @event,
-        ITopicClient topic,
-        INotificationTemplatesClient notificationTemplates,
-        IWorkflowClient workflow,
-        IWorkflowGroupClient workflowGroup,
-        IIntegrationClient integration,
-        INotificationsClient notifications,
-        IMessageClient message,
-        ILayoutClient layout)
-    {
-        Subscriber = subscriber;
-        Event = @event;
-        Topic = topic;
-        NotificationTemplates = notificationTemplates;
-        Workflow = workflow;
-        WorkflowGroup = workflowGroup;
-        Integration = integration;
-        Notifications = notifications;
-        Message = message;
-        Layout = layout;
-    }
-
     public NovuClient(
         INovuClientConfiguration configuration,
         HttpClient? client = default,
@@ -69,7 +40,6 @@ public NovuClient(
         Subscriber = RestService.For<ISubscriberClient>(httpClient, refitSettings);
         Event = RestService.For<IEventClient>(httpClient, refitSettings);
         Topic = RestService.For<ITopicClient>(httpClient, refitSettings);
-        NotificationTemplates = RestService.For<INotificationTemplatesClient>(httpClient, refitSettings);
         WorkflowGroup = RestService.For<IWorkflowGroupClient>(httpClient, refitSettings);
         Workflow = RestService.For<IWorkflowClient>(httpClient, refitSettings);
         Layout = RestService.For<ILayoutClient>(httpClient, refitSettings);
@@ -89,6 +59,5 @@ public NovuClient(
     public ISubscriberClient Subscriber { get; }
     public IEventClient Event { get; }
     public ITopicClient Topic { get; }
-    public INotificationTemplatesClient NotificationTemplates { get; }
     public IWorkflowGroupClient WorkflowGroup { get; }
 }