-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): centralize upsert validation + improve nested error handling #7173
Merged
tatarco
merged 3 commits into
next
from
nv-4918-preview-returns-500-if-the-step-has-a-missing-name
Dec 12, 2024
Merged
fix(api): centralize upsert validation + improve nested error handling #7173
tatarco
merged 3 commits into
next
from
nv-4918-preview-returns-500-if-the-step-has-a-missing-name
Dec 12, 2024
+460
−375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@novu/client
@novu/framework
@novu/headless
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/shared
commit: |
tatarco
commented
Nov 30, 2024
apps/api/src/app/workflows-v2/mappers/notification-template-mapper.ts
Outdated
Show resolved
Hide resolved
...api/src/app/workflows-v2/usecases/upsert-workflow/preferences-request-upsert-data.command.ts
Outdated
Show resolved
Hide resolved
tatarco
force-pushed
the
nv-4918-preview-returns-500-if-the-step-has-a-missing-name
branch
from
December 11, 2024 15:01
111efe9
to
4d1930c
Compare
tatarco
force-pushed
the
nv-4918-preview-returns-500-if-the-step-has-a-missing-name
branch
from
December 12, 2024 05:21
04202ec
to
79534f2
Compare
SokratisVidros
approved these changes
Dec 12, 2024
tatarco
deleted the
nv-4918-preview-returns-500-if-the-step-has-a-missing-name
branch
December 12, 2024 06:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(api): add upsert validation
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer