feat(dashboard): Activity feed panel #7238
Merged
+631
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scopsy
changed the title
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
approved these changes
Dec 10, 2024
Comment on lines
+107
to
+186
| TODO: Missing backend support for digest events widget | ||
| {job.type === 'digest' && job.digest?.events && ( | ||
| <ActivityDetailCard title="Digest Events" expandable={true} open> | ||
| <div className="min-w-0 max-w-full font-mono"> | ||
| {job.digest.events.map((event: DigestEvent, index: number) => ( | ||
| <div key={index} className="group flex items-center gap-2 rounded-sm px-1 py-1.5 hover:bg-neutral-100"> | ||
| <RiCheckboxCircleLine className="text-success h-4 w-4 shrink-0" /> | ||
| <div className="flex items-center gap-2 truncate"> | ||
| <span className="truncate text-xs text-neutral-500">{event.type}</span> | ||
| <span className="text-xs text-neutral-400"> | ||
| {`${format(new Date(job.updatedAt), 'HH:mm')} UTC`} | ||
| </span> | ||
| </div> | ||
| </div> | ||
| ))} | ||
| </div> | ||
| </ActivityDetailCard> | ||
| )} */} |
There was a problem hiding this comment.
How much effort is to enrich the API accordingly?
SokratisVidros
approved these changes
Dec 11, 2024
LetItRock
reviewed
Dec 12, 2024
| ); | ||
| } | ||
|
|
||
| function LoadingSkeleton() { |
There was a problem hiding this comment.
If we have it as a separate component, then whenever we update the layout of the panel or change anything in there, we will need to "remember" to make the same adjustments for the skeleton. Ideally, we should reuse the same layout component or have skeletons embedded into the ActivityPanel.
|
|
||
| export function ActivityDetailCard({ title, timestamp, expandable = false, open, children }: ActivityDetailCardProps) { | ||
| const [internalOpen, setInternalOpen] = useState(false); | ||
| const isExpanded = open ?? internalOpen; |
There was a problem hiding this comment.
We have the accordion primitive that we can use for the nice animation. However, I don't know if it will require doing some updates.
apps/dashboard/src/components/activity/execution-detail-item.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
This PR utilized the existing API without any extra changes there.
Not in scope: Filters, Workflow Editor connectivity
Screenshots
https://www.loom.com/share/0923c3816bbc49fbae494c24266d5c98
Expand for optional sections
Related enterprise PR
Special notes for your reviewer