fix(dashboard): Opt-in new orgs created from org switcher in v2 #7277
+32
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scopsy
commented
Dec 11, 2024
Comment on lines
+15
to
+26
| organizationSwitcherPopoverInvitationActionsBox: 'p-0 pr-2', | ||
| organizationSwitcherInvitationAcceptButton: '!text-[10px] !min-w-[90px] !w-[90px] px-0', | ||
| organizationPreviewMainIdentifier: 'text-foreground-950 text-base', | ||
| organizationPreviewAvatarContainer: 'size-6 rounded-full', | ||
| organizationPreviewAvatarBox: 'rounded-full size-6', | ||
| organizationPreview: 'py-1.5 px-4 gap-2', | ||
| organizationSwitcherPopoverActionButton: 'py-1.5 px-4 -ml-1.5 text-sm gap-0', | ||
| organizationPreview: 'py-1.5 px-2 gap-2', | ||
| organizationSwitcherPopoverActionButton: 'py-1 px-2 -ml-1.5 text-sm gap-0', | ||
| organizationSwitcherPopoverCard: 'w-64', | ||
| organizationSwitcherPreviewButton: 'p-0 [&>svg]:mr-2 !border-0', | ||
| organizationPreviewSecondaryIdentifier: 'hidden', | ||
| organizationSwitcherPopoverActions: | ||
| 'py-2 [&_.cl-organizationPreviewMainIdentifier]:text-sm [&>div:nth-child(2)]:!border-0', | ||
| 'py-0.5 [&_.cl-organizationPreviewMainIdentifier]:text-sm [&>div:nth-child(2)]:!border-0', |
There was a problem hiding this comment.
Something was cmpletly off when a new invitation is available to a user to join an org. Fixed the excess paddings
scopsy
commented
Dec 11, 2024
| <ClerkOrganizationSwitcher | ||
| hidePersonal | ||
| skipInvitationScreen | ||
| afterCreateOrganizationUrl={ROUTES.USECASE_SELECT + '?v2_opt_in=true'} |
There was a problem hiding this comment.
We want to redirect the user and skip the questionnaire straight to the usecase select page
scopsy
commented
Dec 11, 2024
Comment on lines
+14
to
+18
| if (hasV2OptIn) { | ||
| (async () => { | ||
| await optIn(); | ||
| })(); | ||
| } else { |
There was a problem hiding this comment.
Allowing to force opt in if a query param was passed to the url
scopsy
changed the title
SokratisVidros
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer