Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up DbType handling in TypeMappingInfo #4105

Closed
roji opened this issue Nov 7, 2021 · 0 comments · Fixed by #4104
Closed

Clean up DbType handling in TypeMappingInfo #4105

roji opened this issue Nov 7, 2021 · 0 comments · Fixed by #4104
Assignees
@vonzshik
Labels
cleanup
Milestone
6.0.0

Comments

@roji
Copy link
Member

roji commented Nov 7, 2021

TypeMappingInfo shouldn't have DbType - we should just infer it from NpgsqlDbType via a global static table, just like we already do in GlobalTypeMapper.
@roji roji added the cleanup label Nov 7, 2021
@roji roji added this to the 7.0.0 milestone Nov 7, 2021
@roji roji self-assigned this Nov 7, 2021
@vonzshik vonzshik mentioned this issue Nov 8, 2021
Merged
@roji roji modified the milestones: 7.0.0, 6.0.0 Nov 8, 2021
@roji roji assigned vonzshik and unassigned roji Nov 8, 2021
vonzshik added a commit that referenced this issue Nov 8, 2021
@vonzshik @roji
Map DbType.DateTime to timestamptz (#4104)
50cc435 
Closes #4106
Closes #4105

Co-authored-by: Shay Rojansky <roji@roji.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vonzshik vonzshik

Labels
cleanup
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Map DbType.DateTime to timestamptz vonzshik/npgsql
2 participants
@roji @vonzshik