This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 64
[BUG] another peerOptional ERESOLVE case #236
Comments
Ok, took a bit more work to get a reproduction case that actually is broken in the same way. Got to it with this:
PR incoming. |
isaacs
added a commit
that referenced
this issue
Feb 17, 2021
case D ``` root -> (x, z@1) x -> PEEROPTIONAL(y) y -> PEER(z@2) ``` case E ``` root -> (x, z@1) x -> PEEROPTIONAL(y) PEER(z@1) y -> PEER(z@2) ``` case F ``` root -> (x, z@1) x -> PEEROPTIONAL(y) PEER(z@1) PEER(w@1) w -> PEER(z@1) y -> PEER(z@2) ``` Case F properly reproduces the failure seen by installing ng-packagr@11.1.3 alongside typescript@4. Fix: #236 cc: @kyliau
isaacs
added a commit
that referenced
this issue
Feb 17, 2021
case D ``` root -> (x, z@1) x -> PEEROPTIONAL(y) y -> PEER(z@2) ``` case E ``` root -> (x, z@1) x -> PEEROPTIONAL(y) PEER(z@1) y -> PEER(z@2) ``` case F ``` root -> (x, z@1) x -> PEEROPTIONAL(y) PEER(z@1) PEER(w@1) w -> PEER(z@1) y -> PEER(z@2) ``` Case F properly reproduces the failure seen by installing ng-packagr@11.1.3 alongside typescript@4. Fix: #236 cc: @kyliau
isaacs
added a commit
to npm/cli
that referenced
this issue
Feb 18, 2021
* [#1875](#1875) [npm/arborist#230](npm/arborist#230) Set default advisory `severity`/`vulnerable_range` when missing from audit endpoint data ([@isaacs](https://github.com/isaacs)) * [npm/arborist#231](npm/arborist#231) skip optional deps with mismatched platform or engine ([@nlf](https://github.com/nlf)) * [#2251](#2251) Unpack shrinkwrapped deps not already unpacked ([@isaacs](https://github.com/isaacs), [@nlf](https://github.com/nlf)) * [#2714](#2714) Do not write package.json if nothing changed ([@isaacs](https://github.com/isaacs)) * [npm/rfcs#324](npm/rfcs#324) Prefer peer over prod dep, if both specified ([@isaacs](https://github.com/isaacs)) * [npm/arborist#236](npm/arborist#236) Fix additional peerOptional conflict cases ([@isaacs](https://github.com/isaacs))
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Missed a case in #223
This is subtly similar to case A
case A, hidden to not be confusing
But, with the names spelled in such a way that the conflicted dep is not present in the peerSet tree until after the not-required peerOptional meta-peer is added. (They are sorted alphabetically for consistency.)
This code path wasn't being hit previously, and it's what prevents ng-packagr@11.1.3 from being installed alongside typescript@4. Ie,
What / Why
When
Where
How
Current Behavior
Steps to Reproduce
Expected Behavior
Who
References
The text was updated successfully, but these errors were encountered: