fixup! address PR review comments

npm · Nov 3, 2021 · c035821 · c035821
1 parent 3fba006
commit c035821
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/lib/commands/completion.js b/lib/commands/completion.js
@@ -212,7 +212,7 @@ const dumpScript = async () => {
       // Really, one should not be tossing away EPIPE errors, or any
       // errors, so casually.  But, without this, `. <(npm completion)`
       // can never ever work on OS X.
-      // Ignoring coverage, see 'non EPIPE errors cause failures' test.
+      // TODO Ignoring coverage, see 'non EPIPE errors cause failures' test.
       /* istanbul ignore next */
       if (er.errno === 'EPIPE')
         res()

diff --git a/lib/npm.js b/lib/npm.js
@@ -154,7 +154,7 @@ class Npm extends EventEmitter {
     }
   }
 
-  load () {
+  async load () {
     if (!this.loadPromise) {
       process.emit('time', 'npm:load')
       this.log.pause()

diff --git a/lib/utils/npm-usage.js b/lib/utils/npm-usage.js
@@ -31,7 +31,7 @@ Configuration fields: npm help 7 config
 npm@${npm.version} ${dirname(dirname(__dirname))}`
 }
 
-const allCommands = (npm) => {
+const allCommands = async (npm) => {
   if (npm.config.get('long'))
     return usages(npm)
   return ('\n    ' + wrap(cmdList))

diff --git a/test/fixtures/sandbox.js b/test/fixtures/sandbox.js
@@ -292,10 +292,6 @@ class Sandbox extends EventEmitter {
 
     const cmd = this[_npm].argv.shift()
     return this[_npm].exec(cmd, this[_npm].argv)
-    // const cmd = this[_npm].argv.shift()
-    // const impl = await this[_npm].cmd(cmd)
-
-    // return impl.exec(this[_npm].argv)
   }
 
   async complete (command, argv, partial) {