Skip to content

Commit

Permalink
ci: change console.error for console.log (#79)
Browse files Browse the repository at this point in the history
  • Loading branch information
alopezsanchez authored and zkat committed Dec 10, 2018
1 parent 460c0f8 commit d1903d8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/ci.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function ci (args, cb) {
.then(
(details) => {
npmlog.disableProgress()
console.error(`added ${details.pkgCount} packages in ${
console.log(`added ${details.pkgCount} packages in ${
details.runTime / 1000
}s`)
}
Expand Down
10 changes: 4 additions & 6 deletions test/tap/ci.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ test('basic installation', (t) => {
const stdout = ret[1]
const stderr = ret[2]
t.equal(code, 0, 'command completed without error')
t.equal(stdout.trim(), '', 'no output on stdout')
t.equal(stderr.trim(), '', 'no output on stderr')
t.match(
stderr.trim(),
stdout.trim(),
/^added 6 packages in \d+(?:\.\d+)?s$/,
'no warnings on stderr, and final output has right number of packages'
)
Expand Down Expand Up @@ -150,9 +150,9 @@ test('supports npm-shrinkwrap.json as well', (t) => {
const stdout = ret[1]
const stderr = ret[2]
t.equal(code, 0, 'command completed without error')
t.equal(stdout.trim(), '', 'no output on stdout')
t.equal(stderr.trim(), '', 'no output on stderr')
t.match(
stderr.trim(),
stdout.trim(),
/^added 6 packages in \d+(?:\.\d+)?s$/,
'no warnings on stderr, and final output has right number of packages'
)
Expand Down Expand Up @@ -197,10 +197,8 @@ test('removes existing node_modules/ before installing', (t) => {
], EXEC_OPTS))
.then((ret) => {
const code = ret[0]
const stdout = ret[1]
const stderr = ret[2]
t.equal(code, 0, 'command completed without error')
t.equal(stdout.trim(), '', 'no output on stdout')
t.match(
stderr.trim(),
/^npm.*WARN.*removing existing node_modules/,
Expand Down

0 comments on commit d1903d8

Please sign in to comment.