chore: refactor commands #3959
Merged
chore: refactor commands #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests for npm.js and cli.js are not done, that's all that's left before review is ready. |
|
may i ask what is the difference between |
wraithgar
force-pushed
the
gar/refactor-commands
branch
3 times, most recently
from
b021364 to
ec6598a
Compare
wraithgar
force-pushed
the
gar/refactor-commands
branch
from
ec6598a to
16003ff
Compare
darcyclarke
added
semver:patch
wraithgar
force-pushed
the
gar/refactor-commands
branch
from
16003ff to
3fba006
Compare
lukekarrys
approved these changes
Nov 3, 2021
This is the first phase of refactoring the internal structure of the npm commands to set us up for future changes. This iteration changes the function signature of `exec` for all the commands to be a async (no more callbacks), and also groups all the commands into their own subdirectory. It also removes the Proxy `npm.commands` object, in favor of an `npm.cmd` and `npm.exec` function that breaks up the two things that proxy was doing. Namely, getting to the attributes of a given command (`npm.cmd` now does this), and actually running the command `npm.exec` does this. PR-URL: #3959 Credit: @wraithgar Close: #3959 Reviewed-by: @lukekarrys
wraithgar
force-pushed
the
gar/refactor-commands
branch
from
c035821 to
8ffeb71
Compare
Merged
./ is current directory while ../ is the adjacent directory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first phase of refactoring the internal structure of the npm
commands to set us up for future changes. This iteration changes the
function signature of
execfor all the commands to be a async (no morecallbacks), and also groups all the commands into their own
subdirectory.
It also removes the Proxy
npm.commandsobject, in favor of annpm.cmdandnpm.execfunction that breaks up the two things thatproxy was doing. Namely, getting to the attributes of a given command
(
npm.cmdnow does this), and actually running the commandnpm.execdoes this.