Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isaacs/ip remediation #1054

Closed
wants to merge 2 commits into from
Closed

Isaacs/ip remediation #1054

wants to merge 2 commits into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Mar 24, 2020

  • Add note about underscore used as a test fixture.
  • Remove the wealljs CoC and contributing markdowns from node_modules.

We still have to go through and publish legacy versions for all these deps, but at least this way we're not in fuzzy IP licensing territory with shipping the CLI itself.

isaacs added 2 commits March 23, 2020 17:26
@isaacs
Add note about third-party test fixture code
751716d
@isaacs
Do not ship CoC/Contributing files for deps
76b4d09 
Some of these are used under a somewhat ambiguous license, and we're
moving away from the WeAll* stuff to just rely on the centralized npm
code of conduct anyhow.  Better to leave them out for now, as we go
through and update the deps themselves to have a cleaner and more
consistent project setup.
@isaacs isaacs requested a review from darcyclarke March 24, 2020 00:33
@isaacs isaacs requested a review from a team as a code owner March 24, 2020 00:33
@npm-deploy-user
Copy link

angular-quickstart app-large app-medium ember-quickstart react-app
prev current status prev current status prev current status prev current status prev current status
initial install 41s 38.7s✅ 39.5s 36.4s✅ 34.5s 31.8s✅ 28.1s 25.9s✅ 33.5s 29.9s✅
repeat install 9.6s 8.4s✅ 8.6s 8.1s✅ 8.3s 8.7s✅🐌 7.7s 7.5s✅ 9.1s 13s🛑
with warm cache 32.3s 27.9s✅ 33.8s 31s✅ 31.3s 28.9s✅ 23.4s 20.5s✅ 29.1s 27.8s✅
with node_modules 9.2s 9.2s✅🐌 8.6s 7.1s✅ 9s 6.9s✅ 7.8s 6.6s✅ 9.4s 8.6s✅
with lockfile 32.6s 32.6s✅ 31s 27.5s✅ 29s 27.3s✅ 21.7s 19.6s✅ 27.4s 25.4s✅
with warm cache and node_modules 9.3s 8.4s✅ 7.9s 7.4s✅ 8.4s 8.5s✅🐌 7.6s 6.5s✅ 9.2s 7.9s✅
with warm cache and lockfile 24.7s 22.2s✅ 26.3s 25.9s✅ 24.3s 25s✅🐌 17.8s 15.6s✅ 21.3s 20.2s✅
with node_modules and lockfile 10.1s 9.3s✅ 9.8s 8.4s✅ 8.6s 8.4s✅ 7.8s 7.2s✅ 9.7s 8.7s✅

@ruyadorno ruyadorno added Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes labels Mar 24, 2020
@ruyadorno ruyadorno closed this in be37961 Mar 25, 2020
@isaacs isaacs deleted the isaacs/ip-remediation branch October 2, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@darcyclarke darcyclarke Awaiting requested review from darcyclarke

Assignees
No one assigned
Labels
Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacs @npm-deploy-user @ruyadorno