Add support for requiring 2fa to publish specific packages. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarna
force-pushed
the
iarna/per-package-2fa
branch
from
c0e5944 to
74e8b00
Compare
Credit: @iarna
iarna
force-pushed
the
iarna/per-package-2fa
branch
from
74e8b00 to
573ca50
Compare
iarna
changed the title
iarna
commented
Jul 13, 2018
| cb(err, data) | ||
| return Bluebird.try(() => { | ||
| params.auth = auth | ||
| try { |
There was a problem hiding this comment.
This is super weird and actually what the API for this function is... it throws if it's given a command its never heard of, but ALSO takes an errback that it uses for network errors. I suppose it's not that unreasonable... it's like an argument assertion.
Just with promises it feels much weirder.
|
Will this status show up in |
zkat
force-pushed
the
release-next
branch
2 times, most recently
from
614c234 to
322d9c2
Compare
|
This stuff is pretty well tested n-r-c side, so I'll just leave it there. We can write tests for it when this gets ported to n-r-f. This does need to have the |
|
This is getting superseded by #2 so I'm gonna close it. |
1 task
antongolub
pushed a commit
to antongolub-forks/npm-cli
that referenced
this pull request
May 18, 2024
This uses the updated version of gentle-fs which has the binLink method, so that we don't need to fork based on OS, and will always check to ensure that the bin or cmd-shim is a reference into the folder being linked. Also perform a similar check on linked man pages. Fix npm#11 PR-URL: npm/bin-links#12 Credit: @isaacs Close: npm#12 Reviewed-by: @isaacs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nrc PR was: npm/npm-registry-client#175