error-message: strip version info from pkg on E404 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
reviewed
Dec 24, 2018
|
I thought I had seen something like that before, I'll change it in a minute (trying out some tink stuff now). |
zkat
approved these changes
Jan 4, 2019
iarna
suggested changes
Jan 8, 2019
lib/utils/error-message.js
Outdated
| detail.push(['404', '']) | ||
| detail.push(['404', '', "'" + er.pkgid + "' is not in the npm registry."]) | ||
| detail.push(['404', '', "'" + pkg + "' is not in the npm registry."]) |
There was a problem hiding this comment.
Output should still include the version, because if I say npm i npm@20.0.0 I don't want an error saying that npm isn't in the registry.
There was a problem hiding this comment.
Seems I forgot to address this earlier, but I added a fix (not sure why I changed it in the first place).
There was a problem hiding this comment.
Seeing this makes me want to use template literals. =)
zkat
force-pushed
the
release-next
branch
5 times, most recently
from
db63b89 to
b09bc8c
Compare
Keep the version number in the error message. See npm#132 (comment)
This was referenced Feb 1, 2020
This was referenced Sep 15, 2021
This was referenced Sep 27, 2021
This was referenced Sep 28, 2021
This was referenced May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://npm.community/t/4227