Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add --audit-level param #159

Closed
wants to merge 1 commit into from
Closed

Conversation

ngraef
Copy link
Contributor

@ngraef ngraef commented Feb 13, 2019

Make --audit-level an officially documented parameter of npm audit.

Implementation added in #31.

implementation added in npm#31
@ngraef ngraef requested a review from a team as a code owner February 13, 2019 23:54
@ngraef
Copy link
Contributor Author

ngraef commented Feb 14, 2019

Looks like there is similar work in #125 and #135. (Sorry, I should've checked before opening this PR.) However, I believe this change does a better job of documenting the --audit-level parameter, so perhaps some PR consolidation is necessary.

@zkat zkat added the docs label Feb 18, 2019
@zkat zkat changed the base branch from latest to release-next February 18, 2019 22:27
@zkat zkat force-pushed the release-next branch 2 times, most recently from 06cdf5b to f957798 Compare February 20, 2019 20:42
to specify the minimum vulnerability level that will cause the command to fail. This
option does not filter the report output, it simply changes the command's failure
threshold.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tangential - should the underlying option also alter output or should that behavior be introduced under a different parameter?

@isaacs isaacs added the semver:patch semver patch level for changes label Jun 26, 2019
@isaacs
Copy link
Contributor

isaacs commented Jun 26, 2019

This will be in the next release. Thanks!

@isaacs isaacs closed this Jun 26, 2019
@isaacs isaacs mentioned this pull request Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants