Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lib/team.js tweaks and tests #2314

Merged
merged 1 commit into from
Dec 11, 2020
Merged

fix: lib/team.js tweaks and tests #2314

merged 1 commit into from
Dec 11, 2020

Conversation

ruyadorno
Copy link
Contributor

@ruyadorno ruyadorno commented Dec 9, 2020 •
edited
Loading

  • Removes unnecessary colon when listing 0 users/teams
  • Removes unimplemented npm team edit placeholder
  • Adds test/lib/team.js tests
  • Fixes: v7(tests): team statusboard#176

@ruyadorno ruyadorno requested a review from a team as a code owner December 9, 2020 20:18
@ruyadorno ruyadorno added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Dec 9, 2020
@ruyadorno ruyadorno added this to the OSS - Sprint 21 milestone Dec 9, 2020
@ruyadorno ruyadorno self-assigned this Dec 9, 2020
@ruyadorno @isaacs
fix: lib/team.js tweaks and tests
7ff6efb 
- Removes unnecessary colon when listing 0 users/teams
- Removes unimplemented `npm team edit` placeholder
- Adds `test/lib/team.js` tests

- Fixes: npm/statusboard#176

PR-URL: npm#2314
Credit: @ruyadorno
Close: npm#2314
Reviewed-by: @isaacs
@isaacs isaacs changed the base branch from latest to release/v7.1.2 December 11, 2020 19:29
@isaacs isaacs force-pushed the refactor-team-tests branch from 9cb7d62 to 7ff6efb Compare December 11, 2020 19:29
@isaacs isaacs merged commit 7ff6efb into npm:release/v7.1.2 Dec 11, 2020
@isaacs isaacs mentioned this pull request Dec 11, 2020
Merged
This was referenced Dec 11, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ruyadorno ruyadorno

Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
OSS - Sprint 21
Development

Successfully merging this pull request may close these issues.

v7(tests): team
2 participants
@ruyadorno @isaacs