Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: npm search include/exclude #2325

Merged
merged 1 commit into from
Dec 11, 2020
Merged

fix: npm search include/exclude #2325

merged 1 commit into from
Dec 11, 2020

Conversation

ruyadorno
Copy link
Contributor

@ruyadorno ruyadorno commented Dec 10, 2020 •
edited
Loading

  • Fixes npm search --searchexclude=<value> option
  • Tweaks --searchopt logic
  • Refactor and cleanup lib/search.js
  • Add test/lib/search.js tests
  • Fixes: v7(tests): search statusboard#171

@ruyadorno ruyadorno requested a review from a team as a code owner December 10, 2020 22:26
@ruyadorno ruyadorno added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Dec 10, 2020
@ruyadorno ruyadorno added this to the OSS - Sprint 21 milestone Dec 10, 2020
@ruyadorno ruyadorno self-assigned this Dec 10, 2020
@ruyadorno @isaacs
fix: npm search include/exclude
244c206 
- Fixes `npm search --searchexclude=<value>` option
- Tweaks `--searchopt` logic
- Refactor and cleanup `lib/search.js`
- Add `test/lib/search.js` tests

- Fixes: npm/statusboard#171

PR-URL: npm#2325
Credit: @ruyadorno
Close: npm#2325
Reviewed-by: @isaacs
@isaacs isaacs force-pushed the refactor-search-tests branch from f08fa4f to 244c206 Compare December 11, 2020 19:22
@isaacs isaacs changed the base branch from latest to release/v7.1.2 December 11, 2020 19:25
@isaacs isaacs merged commit 244c206 into npm:release/v7.1.2 Dec 11, 2020
@isaacs isaacs mentioned this pull request Dec 11, 2020
Merged
This was referenced Dec 11, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ruyadorno ruyadorno

Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
OSS - Sprint 21
Development

Successfully merging this pull request may close these issues.

v7(tests): search
2 participants
@ruyadorno @isaacs