Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests for npm help #2348

Closed
wants to merge 3 commits into from
Closed

tests for npm help #2348

wants to merge 3 commits into from

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Dec 14, 2020

tests for the help command, also wrapped the call to htmlMan() in a try/catch so that we can appropriately propagate the error back out to the user

References

Closes npm/statusboard#153

@nlf nlf requested a review from a team as a code owner December 14, 2020 21:12
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Dec 15, 2020
@nlf nlf mentioned this pull request Dec 15, 2020
Merged
@nlf nlf closed this in 6caf19f Dec 15, 2020
@MylesBorins MylesBorins mentioned this pull request Dec 16, 2020
Closed
@nlf nlf deleted the nlf/help-tests branch March 28, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcyclarke darcyclarke darcyclarke approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v7(tests): help
3 participants
@nlf @ruyadorno @darcyclarke