Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up flaky tests #240

Closed
wants to merge 1 commit into from
Closed

clean up flaky tests #240

wants to merge 1 commit into from

Commits on Oct 31, 2019

  1. test: Clean up some flakiness and inconsistency 

    * Get rid of a lot of usage of osenv.tmpdir in tests.
* Remove unnecessary creation/deletion of common.pkg
* Reduce rimraf.sync wherever possible (often collides with
  common-tap.js's rimraf on windows)
* Use common test utilities wherever possible.
* DRY tests with test templates where it makes sense.
    @isaacs
    isaacs committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    2f7ec52 View commit details
    Browse the repository at this point in the history