Add CI environment variables to user-agent #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/ci-in-user-agent
branch
from
a2f4950 to
0b25efc
Compare
ruyadorno
approved these changes
Sep 11, 2019
|
This should be quite effective. Easy to parse out, and it is nice to have the additional detail regarding which CI platform is in use. |
- fix: filter functions and undefined out of makeEnv (@isaacs)
- fix: pack git directories properly (@claudiahdz) - respect no-optional argument (@cruzdanilo)
PR-URL: #252 Credit: @claudiahdz Close: #252 Reviewed-by: @mikemimik
It seems that a couple of lines were missed when token.js was [changed to use figgyPudding][1] which [causes an error][2] when trying to run that command in certain circumstances. This patch fixes that error. [1]: 4cf850d#diff-398ed3b014436a5204583323ea29320b [2]: https://npm.community/t/npm-token-err-figgypudding-options-cannot-be-modified-use-concat-instead/10288 PR-URL: #259 Credit: @benblank Close: #259 Reviewed-by: @isaacs
isaacs
force-pushed
the
isaacs/ci-in-user-agent
branch
from
0b25efc to
e590a29
Compare
The `npm-in-ci` header has been sent for some time now by make-fetch-happen, but User-Agent is more reliably logged and respected by proxies and CDNs, so that's a better place to put this.
isaacs
force-pushed
the
isaacs/ci-in-user-agent
branch
from
e590a29 to
3a61f4a
Compare
Merged
This was referenced Oct 26, 2019
This was referenced Nov 5, 2019
This was referenced Nov 14, 2019
This was referenced Dec 5, 2019
This was referenced Dec 18, 2019
This was referenced Jan 17, 2020
This was referenced Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
npm-in-ciheader has been sent for some time now bymake-fetch-happen, but User-Agent is more reliably logged and respected
by proxies and CDNs, so that's a better place to put this.