Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsupported: npm v6.10.0 breaks on node v6.0, v6.1, v9.0 - v9.2 #279

Closed
wants to merge 1 commit into from

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Nov 3, 2019

nvm-sh/nvm@100861d

npm v6.10 caused npm to no longer work on node v6.0, v6.1, v9.0, v9.1, and v9.2.

This PR isn't to debate semver adherence, though, I just want to update the "unsupported" logic to be correct :-)

I'd also like to update the supportedNode list, but it'd need a "max" to be supported, or instead of "min" a semver range, and that seemed like a bigger change.

@ljharb ljharb requested a review from a team as a code owner November 3, 2019 18:02
@ljharb
Copy link
Contributor Author

ljharb commented Nov 3, 2019

The failing test is in "test/tap/all-package-metadata.js" on node 12 in a rimraf call; i wonder if it's flaky and needs to be rerun?

@ljharb ljharb mentioned this pull request Nov 5, 2019
@darcyclarke darcyclarke added release semver:minor new backwards-compatible feature labels Nov 5, 2019
@darcyclarke darcyclarke mentioned this pull request Nov 5, 2019
3 tasks
@ruyadorno ruyadorno closed this in cd14d47 Nov 5, 2019
@ljharb ljharb deleted the patch-1 branch November 5, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor new backwards-compatible feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants