Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): don't pass unused args #2803

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

wraithgar
Copy link
Member

The searchopts get parsed and added to the query elsewhere, they're not
part of the include array they are an extra querystring that is added
to the search request.

These already make it to the search request, this was dead code.

References

Closes #2791

@wraithgar wraithgar requested a review from a team as a code owner March 1, 2021 19:05
@wraithgar wraithgar added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 1, 2021
@ruyadorno ruyadorno added the semver:patch semver patch level for changes label Mar 1, 2021
The searchopts get parsed and added to the query elsewhere, they're not
part of the `include` array they are an extra querystring that is added
to the search request.

PR-URL: #2803
Credit: @wraithgar
Close: #2803
Reviewed-by: @ruyadorno
@ruyadorno ruyadorno changed the base branch from latest to release/v7.6.1 March 4, 2021 21:14
@ruyadorno ruyadorno merged commit 2d682e4 into release/v7.6.1 Mar 4, 2021
This was referenced Mar 12, 2021
@wraithgar wraithgar deleted the gar/searchopts branch November 2, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] search is ignoring --searchopts
2 participants