-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration Definition Refactor, Phase 1 #2878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/config-refactor
branch
4 times, most recently
from
March 16, 2021 00:50
08161ea
to
9013367
Compare
This is ready to review for basic structure and approach, but there are a few blockers to landing it:
|
isaacs
force-pushed
the
isaacs/config-refactor
branch
from
March 16, 2021 22:29
fac742a
to
300ff77
Compare
darcyclarke
added
the
Release 7.x
work is associated with a specific npm 7 release
label
Mar 17, 2021
isaacs
force-pushed
the
isaacs/config-refactor
branch
4 times, most recently
from
March 18, 2021 18:58
d08ed0a
to
0206855
Compare
isaacs
force-pushed
the
isaacs/config-refactor
branch
from
March 18, 2021 18:59
0206855
to
aaafab8
Compare
ruyadorno
pushed a commit
to wallrat/cli
that referenced
this pull request
Mar 29, 2021
The default value for 'maxsockets' was changed during the refactoring in npm#2878 from 50 to 'Inifinity', this PR changes it to the more accurate value of 15, which was the default used in: https://github.com/npm/make-fetch-happen/blob/785af652ec0c8f108a43004903afd2183af93904/agent.js#L15 Fixes npm#2978 PR-URL: npm#2979 Credit: @wallrat Close: npm#2979 Reviewed-by: @ruyadorno Co-authored-by: Gar <gar+gh@danger.computer>
ruyadorno
pushed a commit
that referenced
this pull request
Mar 29, 2021
The default value for 'maxsockets' was changed during the refactoring in #2878 from 50 to 'Inifinity', this PR changes it to the more accurate value of 15, which was the default used in: https://github.com/npm/make-fetch-happen/blob/785af652ec0c8f108a43004903afd2183af93904/agent.js#L15 Fixes #2978 PR-URL: #2979 Credit: @wallrat Close: #2979 Reviewed-by: @ruyadorno Co-authored-by: Gar <gar+gh@danger.computer>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in refactoring our configuration definition, flattening, and documentation.
Still TODO:
npm.flatOptions
in lib/cli, other than passing to dependencies. (@wraithgar is working on this in another PR)saveType
)Furthermore, explore whether the flatOptions dirty flag should be "you need to regenerate all of these", or a dirty flag for the individual fields that might have changed, or just an object full of getters for each one. The current approach (generate flat options if missing, throw away when
config.set()
changes anything) is naive, but simple and probably performant enough.