Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package id in shrinkwrap lifecycle step output #288

Closed
wants to merge 3 commits into from
Closed

Fix package id in shrinkwrap lifecycle step output #288

wants to merge 3 commits into from

Commits on Nov 6, 2019

  1. Fix package id in shrinkwrap lifecycle step output 

    Currently all logging related to shrinkwrap steps reports 'undefined'
for the package in output and log messages.

This is due to the package associated with the `idealTree` being
recreated in the `savePackageJson()` method which precedes these
steps. For now, just copy forward the `_id` attribute which lifecycle
logging expects, but note that mutating `package` here is surprising.

Fixes npm/npm#20756
    @bz2
    bz2 committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    38d91de View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. Avoid the RegExp 's' flag 

    Not supported on node 6 apparently.

Can get the same effect by explictly matching the newline character.
    @bz2
    bz2 committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    b9ebb12 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2020

  1. Tweak code comments and method of restoring id

    @bz2
    bz2 committed May 23, 2020
    Configuration menu
    Copy the full SHA
    ef69276 View commit details
    Browse the repository at this point in the history