fix(config): accept explicit production=false #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyclarke
added
semver:patch
ruyadorno
approved these changes
Mar 24, 2021
ruyadorno
added
the
release: next
This allows for overriding the implicit omit value based on if NODE_ENV=production PR-URL: #2951 Credit: @wraithgar Close: #2951 Reviewed-by: @ruyadorno
ruyadorno
force-pushed
the
gar/explicit-production
branch
from
c689ca7
to
200bee7
Compare
This was referenced Mar 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for overriding the implicit omit value based on if
NODE_ENV=production
References
Fixes #2936