Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v7.12.1 #3224

Merged
merged 17 commits into from
May 10, 2021
Merged

Release/v7.12.1 #3224

merged 17 commits into from
May 10, 2021

Conversation

wraithgar
Copy link
Member

v7.12.1 (2021-05-10)

BUG FIXES

DEPENDENCIES

  • 285976fd1 @npmcli/arborist@2.4.4
    • fix(reify): properly save spec if prerelease
  • f9f24d17c libnpmexec@1.1.1
    • fix(add): Specify 'en' locale to String.localeCompare
  • cb9f17499 glob@7.1.7
    • force 'en' locale in string sorting
  • 24b4e4a41 ignore-walk@3.0.4
    • Avoid locale-specific sorting issues
  • 1eb7e5c7d @npmcli/arborist@2.4.3
    • guard against locale-specific sorting
  • a6a826067 npm-packlist@2.2.2:
    • fix(sort): avoid locale-dependent sorting issues

wraithgar and others added 17 commits May 7, 2021 10:09
* fix(sort): avoid locale-dependent sorting issues
These tests periodically fail in CI, 10 milliseconds is very much not
enough time to account for fuzziness, and 5 minutes is more than enough
precision given the scales of time involved in each test.

PR-URL: #3201
Credit: @wraithgar
Close: #3201
Reviewed-by: @nlf
This adds the 'en' locale to all instances of String.localeCompare
within the CLI codebase.

Tests added for the cases where we're sorting arbitrary user-generated
data.  The tests rely on the fact that 'ch' sorts after 'd' in the
`'sk'` locale, but ahead of `'d'` in the `'en'` locale.  To ensure that
this is the default behavior if no locale is specified, `LC_ALL=sk` is
set in the test environment.

Other instances of `localeCompare` sort data that the cli controls, so
no tests were added.

Re: #2829

PR-URL: #3203
Credit: @isaacs
Close: #3203
Reviewed-by: @ruyadorno
The mocked npm now uses all config defaults, ensuring we don't have bugs
from the disconnect between our currently heavily mocked tests and
reality. Eventually the npm mock will be closer to reality, this moves
the needle.

PR-URL: #3211
Credit: @wraithgar
Close: #3211
Reviewed-by: @ruyadorno
This was working by coincidence in 7.7.6 and before, and broken in the 7.8.0
refactor. Before, it would see there was no "name" in the spec, and then read
your local package.json, and from that get a latest tag. So, if you didn't
have a package.json in your CWD it would fail with an ENOENT trying to read it.

This fixes it for real, so that if you are asking for info from a git spec, it
goes ahead and looks for the `latest` tag (or whatever tag you have configured
as your default).

PR-URL: #3209
Credit: @wraithgar
Close: #3209
Reviewed-by: @ruyadorno
@wraithgar wraithgar requested a review from a team as a code owner May 10, 2021 21:14
@wraithgar wraithgar merged commit 659751f into latest May 10, 2021
@nlf nlf deleted the release/v7.12.1 branch March 28, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants