Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ls): report *why* something is invalid #3460

Merged
merged 1 commit into from
Jun 23, 2021

Commits on Jun 23, 2021

  1. feat(ls): report *why* something is invalid

    This is a papercut that has been driving me crazy when debugging
    ERESOLVE issues.  It's not particularly useful to just say something is
    "invalid", without showing which module's dependency is not being met.
    
    With this commit, it prints all the packages that depend on that
    dependency and do not have their required version met.
    
    This does print multiple times for deduped deps that are invalid, but
    if we skip the printing of the `invalid` label for deduped deps, we end
    up losing information that is only detected later in the tree walk.
    
    PR-URL: #3460
    Credit: @isaacs
    Close: #3460
    Reviewed-by: @nlf
    isaacs authored and wraithgar committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    23ce3af View commit details
    Browse the repository at this point in the history