Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly allow npm help to open file:/// man pages #4026

Closed
wants to merge 0 commits into from

Conversation

wraithgar
Copy link
Member

This url is trusted input as it is generated from our own man pages

@wraithgar wraithgar requested a review from a team as a code owner November 9, 2021 23:22
@wraithgar
Copy link
Member Author

open-url would likely benefit from a refactor but that's a future task

Copy link
Contributor

@isaacs isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, so that's the use case for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants