Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add --dry-run to npm install #41

Merged
merged 1 commit into from
Aug 20, 2018
Merged

docs: add --dry-run to npm install #41

merged 1 commit into from
Aug 20, 2018

Conversation

reconbot
Copy link
Contributor

@reconbot reconbot commented Aug 8, 2018

No description provided.

@reconbot reconbot requested a review from a team as a code owner August 8, 2018 03:39
zkat
zkat suggested changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'd really like this to be added to the npm pack docs, since they both support --dry-run now. Do you mind doing that?

@reconbot reconbot force-pushed the reconbot/install-docs branch from a66d576 to fb90d5f Compare August 9, 2018 03:00
@reconbot reconbot force-pushed the reconbot/install-docs branch from fb90d5f to 406a843 Compare August 9, 2018 03:01
@reconbot
Copy link
Contributor Author

reconbot commented Aug 9, 2018

Happy to, updated the commit and message and improved the language a bit.

zkat
zkat approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@zkat zkat removed the in-progress label Aug 13, 2018
@reconbot
Copy link
Contributor Author

looks like a stalled test

zkat
zkat approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks great. I really hope it helps more people learn about --dry-run on these two commands, which is super handy sometimes 👍

@zkat zkat changed the base branch from latest to release-next August 20, 2018 22:27
@zkat zkat merged commit e2c4aea into npm:release-next Aug 20, 2018
zkat pushed a commit that referenced this pull request Aug 20, 2018
@reconbot @zkat
docs: add --dry-run to install and pack (#41)
de95640 
PR-URL: #41
Credit: @reconbot
Reviewed-By: @zkat
@reconbot
Copy link
Contributor Author

🎉

@gutwrinch gutwrinch mentioned this pull request Oct 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reconbot @zkat @styfle