Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return otplease fn results #4629

Merged
merged 1 commit into from
Mar 29, 2022
Merged

fix: return otplease fn results #4629

merged 1 commit into from
Mar 29, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Mar 29, 2022

Closes #4626

@wraithgar wraithgar requested a review from a team as a code owner March 29, 2022 14:05
@npm-robot
Copy link
Contributor

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 58.560 ±5.50 34.246 ±0.11 20.131 ±0.27 23.144 ±0.79 3.417 ±0.04 3.435 ±0.01 2.759 ±0.03 13.218 ±0.10 2.779 ±0.04 3.954 ±0.03
#4629 58.875 ±4.18 34.948 ±0.24 20.742 ±0.22 23.364 ±0.46 3.442 ±0.05 3.483 ±0.06 2.818 ±0.10 13.570 ±0.08 2.769 ±0.01 3.904 ±0.01
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 41.281 ±0.49 26.990 ±0.12 15.009 ±0.02 16.097 ±0.26 3.112 ±0.02 3.100 ±0.02 2.862 ±0.02 9.843 ±0.14 2.594 ±0.01 3.532 ±0.03
#4629 43.162 ±0.36 27.268 ±0.18 15.405 ±0.09 16.733 ±0.72 3.126 ±0.02 3.155 ±0.01 2.812 ±0.02 10.047 ±0.12 2.650 ±0.02 3.545 ±0.01

@lukekarrys lukekarrys merged commit 8b65bfd into latest Mar 29, 2022
@lukekarrys lukekarrys deleted the gar/otp-return branch March 29, 2022 21:53
@lukekarrys lukekarrys mentioned this pull request Mar 31, 2022
@lukekarrys lukekarrys mentioned this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--otp fails error
3 participants