fix(libnpmexec): workspaces support #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
added
semver:patch
ruyadorno
force-pushed
the
fix-npm-exec-for-workspaces
branch
2 times, most recently
from
0b405af to
dd6530e
Compare
nlf
reviewed
Mar 31, 2022
1 task
ruyadorno
force-pushed
the
fix-npm-exec-for-workspaces
branch
from
dd6530e to
1175520
Compare
|
@nlf after jumping back at the code here I realized that I could get the original bugfix without explicit requiring that arborist-read-data-refactor 😊 I'm going to split these into two separate PRs so that they're more atomic, simpler to review and revert if needed be. So here now is only the change required in |
nlf
approved these changes
Apr 11, 2022
Fixes the proper path location to use when targetting specific workspaces. Fixes: npm#3520 Relates to: npm/statusboard#403
ruyadorno
force-pushed
the
fix-npm-exec-for-workspaces
branch
from
1175520 to
7c1faf5
Compare
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Apr 19, 2022
Refactor / clean up of the logic around reading installed packages. Fixes reading packages from mixed sources (one being from the local installed tree and the other from the registry using pacote.manifest). Makes it so that libnpmexec is always reading from the Arborist actual tree instead of reading `node_modules` from the file system when retrieving local package data. Fixes: npm#3668 Relates to: npm#4643 Relates to: npm#4619 Relates to: npm/statusboard#403
nlf
approved these changes
Apr 19, 2022
lukekarrys
pushed a commit
that referenced
this pull request
Apr 19, 2022
Refactor / clean up of the logic around reading installed packages. Fixes reading packages from mixed sources (one being from the local installed tree and the other from the registry using pacote.manifest). Makes it so that libnpmexec is always reading from the Arborist actual tree instead of reading `node_modules` from the file system when retrieving local package data. Fixes: #3668 Relates to: #4643 Relates to: #4619 Relates to: npm/statusboard#403
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the proper path location to use when targetting specific workspaces.
References
Fixes: #3520
Relates to: npm/statusboard#403