Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _auth tests and update _auth docs #4782

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Apr 20, 2022

Related to #3573 and comments in #2453.

@wraithgar wraithgar requested a review from a team as a code owner April 20, 2022 16:58
@wraithgar
Copy link
Member Author

I'm going to make another commit to this PR updating the description of _auth to outline this

@wraithgar wraithgar changed the title chore(publish): add _auth tests add _auth tests and update _auth docs Apr 20, 2022
@wraithgar wraithgar force-pushed the gar/publish_auth_config branch from fa446dd to dc662e4 Compare April 20, 2022 17:16
@npm-robot
Copy link
Contributor

npm-robot commented Apr 20, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 60.681 ±2.87 34.139 ±0.38 25.074 ±7.50 22.629 ±0.77 3.378 ±0.05 3.373 ±0.02 2.771 ±0.10 12.693 ±0.13 2.737 ±0.04 3.840 ±0.04
#4782 55.649 ±4.53 33.610 ±0.19 31.308 ±16.38 22.165 ±0.94 3.271 ±0.01 3.341 ±0.02 2.661 ±0.09 12.856 ±0.26 2.638 ±0.02 4.062 ±0.03
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 42.094 ±0.99 25.721 ±0.15 14.492 ±0.02 15.846 ±0.05 3.018 ±0.01 3.084 ±0.08 2.867 ±0.19 9.698 ±0.31 2.599 ±0.04 3.475 ±0.12
#4782 41.761 ±0.91 25.959 ±0.47 14.662 ±0.07 15.938 ±0.49 3.100 ±0.03 2.978 ±0.01 2.737 ±0.07 9.497 ±0.22 2.508 ±0.02 3.438 ±0.02

@wraithgar wraithgar force-pushed the gar/publish_auth_config branch from dc662e4 to ea29f95 Compare April 20, 2022 21:08
@lukekarrys lukekarrys merged commit 6cd6831 into latest Apr 21, 2022
@lukekarrys lukekarrys deleted the gar/publish_auth_config branch April 21, 2022 03:16
@ruyadorno ruyadorno mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants