-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support pure web authentication for commands #5098
Conversation
7450283
to
d140e6f
Compare
found 1 benchmarks with statistically significant performance regressions
timing results
|
12b10ba
to
835033d
Compare
3bc3617
to
1298d8e
Compare
Co-authored-by: Jordan Harband <ljharb@gmail.com>
a95b9f6
to
a0fd462
Compare
53443a4
to
38cef3a
Compare
@jumoel the request logging comes from https://github.com/npm/npm-registry-fetch/blob/43c91f5042854705c9d74445d197a138e530a690/lib/check-response.js#L51-L55. I don't see an easy way to avoid this logging 😢 |
Logging works a little weirdly when you have progress bars up. The loglevel is ignored and everything above a certain level automatically shows after the progress bar. Normally output has to go through a "pause" of the progress bar. Typically when you see artifacts like this it is because there was some sort of disconnect between pausing the progress bar and whatever output was done by something in the cli. I'd start by looking at what does output and make sure it only does ut w/ a paused progress (or through npm.output if it's inside the npm codebase itself and not in a dependency) |
Logging concern is fixed in another PR #5172 |
Logging issue is fixed in 1231bf7. Thanks for suggesting the solution @wraithgar.. 🙇🏻 Working demo from local 👇🏻 - Screen.Recording.2022-07-19.at.11.10.02.PM.mov |
4d6b770
to
e1de7fd
Compare
e1de7fd
to
e137c4d
Compare
What
Some operations, such as publish, might require verification.
This adds support for URL-based JSON payloads from the registry, that specify URLs to open and URLs to poll for the verification status.
Why
We want to allow the users to skip having to paste an OTP into the CLI when performing operations that require verification.
Currently, this is enabled for
publish
on the registry.Adding this change in
otplease
allows all operations that require verification to support web based flows in the future.Note to reviewers
To make this PR as easy as possible to review, the commits should be able to be reviewed individually.