-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "windows: Add preliminary WSL support for npm and npx" #527
Conversation
This reverts commit 3471d52.
Tagging @infinnie so this is visible to you as you're the author of the original commit! |
Thanks but no, it did not prevent NPM for Linux from being run. I had wished that it could fall back to the Windows command prompt when the Linux executable is not found. When the corresponding Linux version exists, however, it would be in a position within This, if implemented, would prevent NPM for Windows from running into an error when executed inside WSL. |
@craigloewen-msft @infinnie I've added this PR to the agenda of our Open RFC call happening later today; I encourage you both to join if you'd like to discuss the ideal solution moving forward: npm/rfcs#70 |
Thanks! I'll join the call. |
This reverts commit 3471d52.
What / Why
From my understanding, this change enables npm to detect that it is running inside of WSL, and instead of running the Linux version of npm, it will run the Windows installed version of npm. Would you be able to revert this change?
The reasoning behind this is that this could cause performance and compatibility issues for npm. Users in WSL would be expecting to use the Linux version of npm, and instead routing the command to target the Windows version of npm could cause unexpected problems.
I'm happy to dive into more detail on the reasons why, and thank you for thinking about WSL when you made this change! :)