Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile: fix docs target typo #546

Closed
wants to merge 1 commit into from
Closed

makefile: fix docs target typo #546

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Contributor

A few references to the doc target were not updated to docs in
#274 and resulted in make release
not building the docs.

What / Why

The instructions for maintaining npm in Node.js run make release.

#274 replaced the doc target with docs but didn't update the dependencies for the release target which meant the docs are not built.

References

@richardlau
makefile: fix docs target typo
0327b82 
A few references to the `doc` target were not updated to `docs` in
npm#274 and resulted in `make release`
not building the docs.
@richardlau richardlau requested a review from a team as a code owner December 2, 2019 23:54
@richardlau richardlau mentioned this pull request Dec 3, 2019
Closed
@mikemimik mikemimik added semver:patch semver patch level for changes Release 6.x work is associated with a specific npm 6 release Bug thing that needs fixing labels Dec 3, 2019
@mikemimik mikemimik added this to the Release 6.14.0 milestone Dec 3, 2019
@mikemimik mikemimik self-assigned this Dec 3, 2019
@mikemimik mikemimik closed this in 4429645 Dec 3, 2019
@mikemimik mikemimik mentioned this pull request Dec 3, 2019
Closed
This was referenced Dec 12, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 20, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
This was referenced Jan 17, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Feb 11, 2020
Open
This was referenced Feb 25, 2020
Open
Open
This was referenced Mar 10, 2020
Open
Merged
This was referenced Mar 19, 2020
Open
Open
Open
Open
Open
This was referenced Mar 26, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 26, 2020
Closed
This was referenced Apr 11, 2020
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Jun 1, 2023
Open
@CALISOULB CALISOULB mentioned this pull request Jun 20, 2023
Open
@hojatA1 hojatA1 mentioned this pull request Jun 20, 2023
Open
@baby636 baby636 mentioned this pull request Jun 21, 2023
Open
@kevinjm39 kevinjm39 mentioned this pull request Jun 21, 2023
Open
This was referenced Jun 21, 2023
Open
Open
@mtdev2 mtdev2 mentioned this pull request Jun 22, 2023
Open
@EMWickd EMWickd mentioned this pull request Jun 22, 2023
Open
@Bhanditz Bhanditz mentioned this pull request Jun 22, 2023
Open
@jackromo888 jackromo888 mentioned this pull request Jun 27, 2023
Open
@nicholaschoi168 nicholaschoi168 mentioned this pull request Jun 28, 2023
Open
@f4lco0n f4lco0n mentioned this pull request Jun 28, 2023
Open
@Mary12jo33 Mary12jo33 mentioned this pull request Jun 29, 2023
Open
@NOUIY NOUIY mentioned this pull request Jun 29, 2023
Open
@NOUIY NOUIY mentioned this pull request Jul 7, 2023
Open
@NOUIY NOUIY mentioned this pull request Jul 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees

@mikemimik mikemimik

Labels
Bug thing that needs fixing Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Milestone
Release 6.13.2
Development

Successfully merging this pull request may close these issues.

Build npm docs
3 participants
@richardlau @ruyadorno @mikemimik