Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engines and Node 18+Windows tests #5475

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Engines and Node 18+Windows tests #5475

merged 3 commits into from
Sep 8, 2022

Commits on Sep 8, 2022

  1. feat: update supported node engines in package.json 

    This also replaces the previous check for known broken versions of node
with an exception handler for syntax errors in order to try and give a
nicer error message when attempting to run npm on older node versions.

BREAKING CHANGE: `npm` is now compatible with the following semver range
for node: `^14.17.0 || ^16.13.0 || >=18.0.0`

Ref: npm/statusboard#519
    @wraithgar
    wraithgar committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    672e11f View commit details
    Browse the repository at this point in the history

  2. fix: attempt more graceful failure in older node versions

    @wraithgar
    wraithgar committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    1ea3c2c View commit details
    Browse the repository at this point in the history

  3. chore: fix failing tests in windows + node 18 

    Some of our tests were failing in windows after testing on node 18. The
reason was the inability to clean up the logs dir. This changes forces
a few tests to run in order and also cleans up any use of multiple
`t.testdir` calls in a single child test which can cause problems.
    @lukekarrys @wraithgar
    lukekarrys authored and wraithgar committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    036d25c View commit details
    Browse the repository at this point in the history