fix: ensure Arborist constructor gets passed around everywhere for pacote #5634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since pacote now requires the Arborist constructor in order to pack a tarball for git dependencies, and that tarball can be packed as part of fetching the packument or the manifest, the easiest solution seemed to be adding the Arborist constructor directly into flatOptions. this gets it sent everywhere consistently with one change instead of having to track down every single call to pacote.
we need to circle back to fix this dependency loop at some point anyway, so this technical debt felt appropriate to buy us the time to do so.