docs: name and version description change #5753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reducing redundancy by deleting repeated code and changing other slight things about those two fields.
lukekarrys
suggested changes
Oct 27, 2022
There was a problem hiding this comment.
Thank you for the PR! There's some ongoing discussion about how to handle the required-ness of name and version. I think there's a little more nuance than them being strictly required or optional. npm/documentation#134
Can you update this PR to remove those parts of the changes?
|
Not sure if this is what you mean, but I changed some things about requiredness... Is there something else I should delete? |
lukekarrys
approved these changes
Oct 28, 2022
|
Thanks for the updates! I think this looks good now. |
wraithgar
reviewed
Nov 1, 2022
wraithgar
reviewed
Nov 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reducing redundancy by deleting repeated code and changing other slight things about those two fields.