Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arborist test coverage #6022

Merged
merged 3 commits into from
Jan 10, 2023
Merged

arborist test coverage #6022

merged 3 commits into from
Jan 10, 2023

Conversation

wraithgar
Copy link
Member

removing arborist coverage map and fixing coverage holes discovered by doing so.

@wraithgar
Copy link
Member Author

resolve overrides coverage test still needs to be written.

@wraithgar wraithgar marked this pull request as ready for review January 4, 2023 19:07
@wraithgar wraithgar requested a review from a team as a code owner January 4, 2023 19:07
nlf
nlf approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and tidy. i have no concerns about removing this particular optimization since it's unlikely to benefit from what's here anyway.

removing the coverage map is a major +1 from me

@lukekarrys lukekarrys merged commit b584af0 into latest Jan 10, 2023
@lukekarrys lukekarrys deleted the gar/arborist-tests branch January 10, 2023 22:10
@github-actions github-actions bot mentioned this pull request Jan 10, 2023
Merged
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wraithgar @nlf @lukekarrys