Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unpublish with scoped registry #6082

Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix: unpublish with scoped registry #6082

merged 1 commit into from
Feb 1, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Jan 24, 2023

Unpublish now works if you have a scoped registry config

Closes #5685

Unpublish now works if you have a scoped registry config
@wraithgar wraithgar requested a review from a team as a code owner January 24, 2023 18:20
@npm-cli-bot
Copy link
Collaborator

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 36.976 ±4.22 15.562 ±0.05 14.317 ±0.14 16.702 ±0.69 2.637 ±0.03 2.714 ±0.05 2.175 ±0.01 10.025 ±0.12 2.127 ±0.02 3.750 ±0.65
#6082 42.583 ±2.83 15.260 ±0.07 14.209 ±0.08 16.707 ±0.13 2.623 ±0.00 2.657 ±0.01 2.061 ±0.04 9.813 ±0.03 2.114 ±0.03 3.211 ±0.04
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 25.525 ±0.44 12.409 ±0.03 11.078 ±0.10 11.886 ±0.27 2.494 ±0.03 2.399 ±0.00 2.232 ±0.01 7.595 ±0.03 2.089 ±0.01 4.724 ±2.53
#6082 28.654 ±4.78 12.085 ±0.14 11.180 ±0.15 11.811 ±0.18 2.447 ±0.03 2.462 ±0.01 2.129 ±0.05 7.569 ±0.06 1.986 ±0.01 2.943 ±0.13

@fritzy fritzy merged commit 1525a5e into latest Feb 1, 2023
@fritzy fritzy deleted the gar/unpublish-npmrc branch February 1, 2023 22:07
@github-actions github-actions bot mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm unpublish fails if scope is involved
4 participants