fix: Do not log warnings about log cleanup when logs_max=0 #6271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you clean up the linting error and add a test? |
|
@wraithgar: Sure, no problem! The CI was delayed in running for some reason. |
|
CI has to be manually run on PRs from forks. You can run |
|
@wraithgar: Test added and lint fixed. |
wraithgar
changed the title
wraithgar
approved these changes
Mar 22, 2023
|
@wraithgar: thanks for reviewing. I squashed my commits because of commit lint. 👍 |
Merged
|
@jmealo that's fine, we usually squash when landing PRs like this anyways, and use the PR title. This is what I ended up doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables logging warnings for failures to cleanup log files when log files are disabled.
References
Fixes #6270