chore: convert more util tests to use mock-npm #6475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/more-mock-npm
branch
2 times, most recently
from
d4dd7ed
to
5f3ccf0
Compare
lukekarrys
force-pushed
the
lk/more-mock-npm
branch
from
5f3ccf0
to
5681266
Compare
wraithgar
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the last remaining tests inside
test/lib/utils/to usemock-npmin place of passing in a static npm-ish object. I had this as part of #6020 originally but I'm pulling out the relevant pieces of that PR into separate PRs.This is what originally caught the bug where
--browserwould always coerce the value to a string (ref #6313). These tests assert for the current broken behavior and can be fixed along with fixing that bug (or removing that behavior entirely for the--browserflag).