-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add package-lock modes to query and audit #6732
Conversation
wraithgar
commented
Aug 24, 2023
- feat: add package-lock-only mode to npm query
- feat: add no-package-lock mode to npm audit
Folks have been asking for this for a LONG time (the audit feature), this should definitely be backported to npm 9. |
found 18 benchmarks with statistically significant performance improvements
timing results
|
6328343
to
69ed983
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the query
command, I noticed that you added the loadVirtual
support to the exec
function, but not the execWorkspaces
function. Was that an oversight, or does the --package-lock-only
option not work when using workspaces?
That's an oversight. A lot of other commands' execWorkspaces just iterate workspaces and call |
Workspaces mode for |
69ed983
to
936a143
Compare
NICE ! |
Thanks for npm/cli#6732 !
Thanks for this; I've now end-of-lifed https://npmjs.com/aud since it's no longer needed. |